Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync upstream v1.30.1 #317

Conversation

sssash18
Copy link

@sssash18 sssash18 commented Jul 8, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #304

Special notes for your reviewer:

Release note:

- Synced changes till v1.30.1 of upstream autoscaler.

k8s-ci-robot and others added 30 commits January 31, 2024 05:50
This change adds the informer factory as an argument to the
`buildCloudProvider` function for clusterapi so that building with tags
will work properly.
…-owner-ref

[VPA] check OwnerRef against TargetRef to confirm VPA/Pod association
…c-improvement

doc: cluster-autoscaler: Oracle provider: Add small security note
…ar-to-reviewers

chore:  add vadasambar to cluster-autoscaler reviewers
…s_equinixmetal

Added the RBAC Permission to equinixmetal Cloud Provider.
…enaming

Update Auto Labels of Subprojects
chore: remove unused arg from StaticAutoScaler
…mCloudProvider-panic

fix: panic in deleteNodesFromCloudProvider
Stop (un)tainting nodes from unselected node groups.
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 9, 2024
@sssash18 sssash18 marked this pull request as ready for review July 15, 2024 05:05
@sssash18 sssash18 changed the title Sync upstream v1.30.0 Sync upstream v1.30.1 Jul 15, 2024
@@ -0,0 +1,4061 @@
I0708 14:05:09.210791 60673 main.go:647] Cluster Autoscaler 1.30.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is added by error I guess. Can you please remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 17, 2024
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Few minor changes requested. Please address them

Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Few minor changes requested. Please address them

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Jul 24, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 24, 2024
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 25, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 25, 2024
@aaronfern aaronfern merged commit e9e32f3 into gardener:machine-controller-manager-provider Jul 25, 2024
9 of 10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue for - Sync with Upstream v1.30