Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate instance status state when machine.Status.LastOperation.Type is Create #309

Conversation

rishabh-11
Copy link

@rishabh-11 rishabh-11 commented Jul 4, 2024

What this PR does / why we need it:
This PR modifies the code to make sure that the instance status is populated with a state in case where machine is in Creation stage.

Which issue(s) this PR fixes:
Fixes #307

Special notes for your reviewer:

Release note:

Fixed a bug where the instance status was nil when `machine.Status.LastOperation.Type` = `Create` causing it to not be considered as an unregistered Node and thereby cluster autoscaler never removing it

@gardener-robot gardener-robot added the needs/review Needs review label Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@gardener-robot gardener-robot added the size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) label Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
Copy link

@aaronfern aaronfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rishabh-11 rishabh-11 self-assigned this Jul 4, 2024
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jul 4, 2024
@aaronfern aaronfern merged commit 1be6cca into gardener:machine-controller-manager-provider Jul 4, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
@rishabh-11 rishabh-11 deleted the instance-status branch July 4, 2024 08:14
@rishabh-11 rishabh-11 mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect cloudprovider instances returned when fetching instances for machine deployments
4 participants