Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #160 on rel-v1.22: No scale down during rolling update #208

Merged
merged 5 commits into from
Apr 10, 2023
Merged

Automated cherry pick of #160 on rel-v1.22: No scale down during rolling update #208

merged 5 commits into from
Apr 10, 2023

Conversation

himanshu-kun
Copy link

@himanshu-kun himanshu-kun commented Apr 10, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds changes to avoid any scale-down (scale-down due to underutilization was already stopped earlier using the scale-down-disabled annotation) like removal of longUnregistered nodes or removal of registered but long not Ready nodes.

Which issue(s) this PR fixes:
Fixes #30

Special notes for your reviewer:
Part of fix as per solution proposed here

Logic relies on the Progressing condition of machineDeployment.

Release note:

- Autoscaler would not scale-down if the node-grp(i.e. machineDeployment) is under rolling update. 
- Logic of fixing up the node grp size for node grp, whose current size not equals expected size for long time , is also disabled.

@himanshu-kun himanshu-kun requested review from unmarshall and a team as code owners April 10, 2023 09:04
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Apr 10, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2023
@himanshu-kun himanshu-kun changed the title Automated cherry pick of #160: fixNodeGroupSize logic silenced Automated cherry pick of #160 on rel-v1.22: No scale down during rolling update Apr 10, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Apr 10, 2023
rishabh-11
rishabh-11 approved these changes Apr 10, 2023
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Apr 10, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Apr 10, 2023
@rishabh-11 rishabh-11 merged commit eb8af58 into gardener:rel-v1.22 Apr 10, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@rishabh-11 rishabh-11

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@himanshu-kun @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot