Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exceptions that occur when reading properties #98

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

Ovizro
Copy link
Contributor

@Ovizro Ovizro commented Sep 19, 2023

A simple fix for #97 .

@Ovizro Ovizro changed the title Suppress exceptions that occur when reading propertiessuppress attribute error Suppress exceptions that occur when reading properties Sep 19, 2023
@gaogaotiantian
Copy link
Owner

要写个test case~保证覆盖率。同时避免regression。

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (096bc73) 100.00% compared to head (d6cf58d) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          378       381    +3     
=========================================
+ Hits           378       381    +3     
Files Changed Coverage Δ
src/objprint/objprint.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ovizro
Copy link
Contributor Author

Ovizro commented Sep 20, 2023

简单写了一个测试,天哥看看可以吗

@gaogaotiantian gaogaotiantian merged commit e808fc8 into gaogaotiantian:master Sep 21, 2023
18 checks passed
@Ovizro Ovizro deleted the fix-attr-err branch September 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants