Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add goreleaser action for streamlined releases #171

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

particledecay
Copy link

@particledecay particledecay commented Apr 9, 2024

Hello, I would like to make Gametime a better place by contributing the following code:

Feature/bug description

Add goreleaser for creating GitHub releases with cross-platform binaries upon tagging the repo.

This is how I decided to implement/fix it

I added Goreleaser to the project. It is a tool that automates the process of releasing Go binaries. It creates GitHub releases with cross-platform binaries upon tagging the repo.

I chose this over Google's slightly more automated release-please-action because this repo doesn't strictly conform to Conventional Commits, so I'm not sure what would happen exactly with semantic version bumps and changelogs.

This supports the following OSes:

  • Linux
  • MacOS
  • Windows

... and will build binaries for various architectures.

What does this change affect? (What can this break?)

It affects strictly the build process, so nothing in particular should break (current build artifacts are opinionated).

How has this been tested

It hasn't.

Observability

Before opening a PR consider whether you have added sufficient observability, do you need to add any datadog additional metrics or spans?

  • Do your metrics follow the naming conventions?

How will this change be monitored

@particledecay particledecay marked this pull request as ready for review April 9, 2024 13:52
@particledecay
Copy link
Author

particledecay commented Apr 9, 2024

Based on PLT-157, there's already apparently a ticket for using release-please-action, hmm... @davekonopka do you think this would conflict with that? I'd prefer to use release-please-action but don't think it's a requirement for this repo. What do you think?

@particledecay particledecay merged commit c54f68c into master Apr 10, 2024
1 check passed
@particledecay particledecay deleted the releaser_action branch April 10, 2024 15:32
@particledecay
Copy link
Author

Confirmed with @davekonopka that this wouldn't conflict. While release-please-action does more and seems promising, it's more dependent on following Conventional Commit standard, which only Platform's repos do at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants