Fix numerous issues with tool input format "21.01" #19030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
force-pushed
the
fixes_for_21.01
branch
from
a81609c
to
5abeaf9
Compare
jmchilton
force-pushed
the
fixes_for_21.01
branch
from
5abeaf9
to
6d7842e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18984 and many related issues - builds on work in #19027. Part of this work is migrating tool execution tests around these things into the new format introduced in #18977 which now has a compact syntax and fixture support for testing both input formats with the same test method. I will hopefully be able to just add another fixture param element for the tool request API (#17393) in order to make sure all these tests work with the new API.
How to test the changes?
(Select all options that apply)
License