Add author and tools details in RO-Crate #18820
Conversation
github-actions
bot
added
the
area/database
There was a problem hiding this comment.
Very nice. Any chance you could also add or extend tests ? 3dbe289#diff-9f3ad661ca1701467f48508ea79951efe90aa29a6d02dec3f2998d831e755bb4 contains the existing examples.
|
Thanks a lot for the review and help @mvdbeek ! |
|
@OliverWoolland could you review this? I think this solves many of the issues you had about the Workflow Run Crate from Galaxy |
|
TO DO in a 2nd time (maybe in a later PR but I'm just putting that here to keep it in mind):
|
| "name": tool_name, | ||
| "version": tool_version, | ||
| "description": tool_description, | ||
| "url": "https://toolshed.g2.bx.psu.edu", # URL if relevant |
There was a problem hiding this comment.
This is not always true. Tools could come from multiple toolsheds.
|
|
||
| # Add tools used in the workflow | ||
| self._add_tools(crate) | ||
| self._add_steps(crate) |
There was a problem hiding this comment.
Workflows can have workflow inputs. Should we add them here as well? At least the types of the workflow inputs?
|
Quick update from the RO-Crate side (with apologies from the long delay) - the metadata that's being added looks fine to me as I read the code, but I would like to look at an example RO-Crate generated using this PR to make sure the JSON-LD output looks like it should. I'm waiting for @pauldg or @OliverWoolland to provide me with such a crate, whoever gets there first |
Here we go again !
I am launching this PR on a bit of work I did to ameliorate the RO-Crate plugin.
I updated the
_add_worfklowfunction. I added the information on the author of the workflow:The update checks if the workflow attribute 'creator_metadata' exist. If it exists, it writes into the ro-crate the name of the creator (if there is no name it leaves a "") same for the idenifier (by default i put the ORCID maybe it's not a good Idea and if there is no Orcid it leaves a ""). If there is no 'creator_metadata' nothing is written on the creator.
I created a function
_add_toolsthat checks the different info inworkflow.stepsto add some tools details:I am not sure if I wrote that the correct way corresponding to the run crate profile (this is a bit obscure to me)
@pauldg What do you think of this ?
Thanks !!