Place invocation state in list #17708
Draft
+646
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also added modifications to the Summary tab here: #17413, which will work nicely with these changes! |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
00de142
to
ec403cc
Compare
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
b47999a
to
31d9b48
Compare
|
Errors seem related - might close this out and get smaller pieces merged first to narrow things down. |
jmchilton
force-pushed
the
place_state_in_invocation_list
branch
from
31d9b48
to
1f0731e
Compare
2 tasks
|
@ahmedhamidawan I stopped working on this because I thought your work superseded it but @mvdbeek mentioned maybe this was still useful. If that is the case, let me know and I can try to rebase it against your latest work or alternatively feel free to pull the bits and pieces of out of this that are useful if any of them are. |
|
This is waiting on #18615 |
4 tasks
ahmedhamidawan
force-pushed
the
place_state_in_invocation_list
branch
from
1f0731e
to
b06cc8e
Compare
ahmedhamidawan
force-pushed
the
place_state_in_invocation_list
branch
from
b06cc8e
to
bb96e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual invocation state we decided wasn't very useful at the team meeting. Foregrounding the progress bars is a potential improvement. I've done some query optimization for this.
Screen.Recording.2024-03-13.at.5.20.19.PM.mov
How to test the changes?
(Select all options that apply)
License