Vendorise packaging.versions.LegacyVersion
#16058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from packaging 21.3 .
This allows us to unpin
packaging
. Fix #15898 .Additionally:
packaging.version.Version()
instead ofpackaging.version.parse()
for parsing versions of Galaxy, Pulsar, conda and conda-build, i.e. assume these are always PEP-440 compliant.galaxy.tool_util.version.parse_version()
(equivalent topackaging.version.parse()
from packaging 21.3) for parsing (possibly non-PEP440-compliant) versions of Galaxy tools and conda packages (there is e.g. a samtools-1.2.rglab package in the bioconda channel).This is the first step to fix the Galaxy tool sorting issue partially addressed by #13570 .
How to test the changes?
(Select all options that apply)
License