feat: bonds #645
feat: bonds #645
Conversation
|
New crates:
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 68.08% 68.22% +0.13%
==========================================
Files 153 156 +3
Lines 11692 11789 +97
==========================================
+ Hits 7961 8043 +82
- Misses 3731 3746 +15
☔ View full report in Codecov by Sentry. |
| amount: T::Balance, | ||
| maturity: Moment, | ||
| ) -> DispatchResult { | ||
| let who = T::IssueOrigin::ensure_origin(origin)?; |
There was a problem hiding this comment.
ok. I will remove the config param. The idea was to have it configurable, but configure it so that everyone can do that.
There was a problem hiding this comment.
no need to configure it if anyone can do it
There was a problem hiding this comment.
but we could keep it if we plan to enable this for others only later
|
|
||
| // Bonds | ||
| parameter_types! { | ||
| pub ProtocolFee: Permill = Permill::from_percent(2); |
There was a problem hiding this comment.
this fee is rather large... how it was determined?
There was a problem hiding this comment.
Oh. I just needed to use some value. We need to discuss and determine what value to use.
| @@ -0,0 +1,76 @@ | |||
| // This file is part of HydraDX. | |||
No description provided.