feat: update xcm config #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 134 134
Lines 9749 9749
=======================================
Hits 6315 6315
Misses 3434 3434
☔ View full report in Codecov by Sentry. |
|
Can you add description why the computedorigin is required ? |
mrq1911
reviewed
Jul 3, 2023
| @@ -192,7 +199,7 @@ impl pallet_xcm::Config for Runtime { | |||
| type SendXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
| type XcmRouter = XcmRouter; | |||
| type ExecuteXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
| type XcmExecuteFilter = Everything; | |||
| type XcmExecuteFilter = Nothing; | |||
There was a problem hiding this comment.
if this is the case i would reconsider this change and at least specify some more permissive filter specific to this use-case
There was a problem hiding this comment.
I would say it makes sense to define the more permissive filter in the context of the ExchangeAsset stuff, not here.
apopiak
approved these changes
Jul 24, 2023
apopiak
reviewed
Jul 27, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a discussion with @apopiak, where we reviewed the XCM changes proposed by the Substrate builders programme in this PR #591, we decided to make the following changes:
WithComputedOriginderivative barrier withAllowTopLevelPaidExecutionFromandAllowSubscriptionsFrombarriers. This outer barrier computes the effective origin (checks for any origin altering operations) and passes this updated origin to inner barriers.XcmExecuteFilterfromEverythingtoNothing. This change disallowspallet_xcm::executeextrinsic which allows sending arbitrary XCM messages. We are not aware of any issues with this param set toEverything, but better be sure. Moreover,pallet_xcmis blocked by the runtime call filter.