-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update xcm config #623
Conversation
Crate versions that have been updated:
Runtime version has been increased. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #623 +/- ##
=======================================
Coverage 64.77% 64.77%
=======================================
Files 134 134
Lines 9749 9749
=======================================
Hits 6315 6315
Misses 3434 3434
☔ View full report in Codecov by Sentry. |
Can you add description why the computedorigin is required ? |
@@ -192,7 +199,7 @@ impl pallet_xcm::Config for Runtime { | |||
type SendXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
type XcmRouter = XcmRouter; | |||
type ExecuteXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
type XcmExecuteFilter = Everything; | |||
type XcmExecuteFilter = Nothing; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is the case i would reconsider this change and at least specify some more permissive filter specific to this use-case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say it makes sense to define the more permissive filter in the context of the ExchangeAsset stuff, not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine after adjusting computed origin count
Based on a discussion with @apopiak, where we reviewed the XCM changes proposed by the Substrate builders programme in this PR #591, we decided to make the following changes:
WithComputedOrigin
derivative barrier withAllowTopLevelPaidExecutionFrom
andAllowSubscriptionsFrom
barriers. This outer barrier computes the effective origin (checks for any origin altering operations) and passes this updated origin to inner barriers.XcmExecuteFilter
fromEverything
toNothing
. This change disallowspallet_xcm::execute
extrinsic which allows sending arbitrary XCM messages. We are not aware of any issues with this param set toEverything
, but better be sure. Moreover,pallet_xcm
is blocked by the runtime call filter.