-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new particle renderer #1682
Add new particle renderer #1682
Conversation
* dev/1.1: `SkinnedMeshRenderer` support immediate initialization of `rootBone` and `bones` (galacean#1672) Support camera depth texture (galacean#1658)
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1682 +/- ##
===========================================
- Coverage 62.16% 60.83% -1.34%
===========================================
Files 430 467 +37
Lines 22542 23316 +774
Branches 3202 3317 +115
===========================================
+ Hits 14014 14184 +170
- Misses 7299 7904 +605
+ Partials 1229 1228 -1
☔ View full report in Codecov by Sentry. |
this._gl = rhi.gl; | ||
} | ||
|
||
/** | ||
* Draw the primitive. | ||
*/ | ||
draw(shaderProgram: any, subMesh: SubMesh): void { | ||
draw(shaderProgram: any, subMesh: SubPrimitive): void { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it more appropriate to change the second parameter name from subMesh to subPrimitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! I will opt this later
* dev/1.1: Fix delay add scene can't fire `onEnbaleInScene` bug (galacean#1725) Fix multi scene script error and GC problem (galacean#1724) fix: glTF parser error and test case (galacean#1723) fix: Script onDisable error (galacean#1719) "v1.1.0-alpha.2" Add physic unit test timeout (galacean#1717) "v1.0.0-beta.20" Fix `PhysicManager` fixedTimeStep less than 0 bug (galacean#1715) Fix physx unit test (galacean#1714) Fix a series of physical system problems (galacean#1712) Fix avoid destroyed material error (galacean#1705) # Conflicts: # packages/core/package.json # packages/design/package.json # packages/draco/package.json # packages/galacean/package.json # packages/loader/package.json # packages/math/package.json # packages/physics-lite/package.json # packages/physics-physx/package.json # packages/rhi-webgl/package.json
Please check if the PR fulfills these requirements
Example: galacean/galacean.github.io#768
Major changes:
Camera
addcamera_Forward
andcamera_Up
build-in shader variableRand
classParticleRenderer