This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add optimize_gas param for create_access_list #2789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To override balances when simulating transactions, we need to figure out the access list for the balanceOf of a token
On Erigon, the gas is optimized so the access list returned is empty (which is different than geth). To get it anyway, we need to pass in an additional
optimizeGas
boolean flag for theeth_createAccessList
call. Since geth is unavailable on Gnosis chain, we need to add the functionality of the PR to achieve the desired outcome.More information: erigontech/erigon#9444
Solution
This PR adds an optional
optimize_gas
(defaults to true) flag for thecreate_access_list
method, that only gets applied if the node client is Erigon.Please let me know if it's good or if I can improve anything!
PR Checklist
create_access_list
, so didn't extend it)