Skip to content

Commit

Permalink
- apply rewording suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
gabrielcocenza committed Apr 24, 2024
1 parent 867b9c6 commit dcfd5b4
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 17 deletions.
2 changes: 1 addition & 1 deletion cou/apps/auxiliary.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ def channel_codename(self) -> OpenStackRelease:
if not compatible_os_releases:
raise ApplicationError(
f"Channel: {self.channel} for charm '{self.charm}' on series '{self.series}' is "
f"currently not supported in this tool. Please take a look at the documentation: "
f"not supported by COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html to see "
"if you are using the right track."
)
Expand Down
3 changes: 1 addition & 2 deletions cou/apps/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -789,8 +789,7 @@ def _check_channel(self) -> None:

raise ApplicationError(
f"Channel: {self.channel} for charm '{self.charm}' on series "
f"'{self.series}' is currently not supported in this tool. Please take a look at the "
"documentation: "
f"'{self.series}' is not supported by COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html to see if "
"you are using the right track."
)
Expand Down
16 changes: 8 additions & 8 deletions tests/unit/apps/test_auxiliary.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,8 +335,8 @@ def test_auxiliary_upgrade_plan_unknown_track(model):
"""Test auxiliary upgrade plan with unknown track."""
channel = "2.0/stable"
exp_msg = (
f"Channel: {channel} for charm 'rabbitmq-server' on series 'focal' is currently "
"not supported in this tool. Please take a look at the documentation: "
f"Channel: {channel} for charm 'rabbitmq-server' on series 'focal' is not supported by "
"COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html "
"to see if you are using the right track."
)
Expand Down Expand Up @@ -398,8 +398,8 @@ def test_auxiliary_raise_error_unknown_series(model):
series = "foo"
channel = "3.8/stable"
exp_msg = (
f"Channel: {channel} for charm 'rabbitmq-server' on series '{series}' is currently "
"not supported in this tool. Please take a look at the documentation: "
f"Channel: {channel} for charm 'rabbitmq-server' on series '{series}' is not supported by "
"COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html "
"to see if you are using the right track."
)
Expand Down Expand Up @@ -436,8 +436,8 @@ def test_auxiliary_raise_error_os_not_on_lookup(current_os_release, model):
"""
current_os_release.return_value = OpenStackRelease("diablo")
exp_error_msg = (
"Channel: 3.8/stable for charm 'rabbitmq-server' on series 'focal' is currently not "
"supported in this tool. Please take a look at the documentation: "
"Channel: 3.8/stable for charm 'rabbitmq-server' on series 'focal' is not supported by "
"COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html to see if you "
"are using the right track."
)
Expand Down Expand Up @@ -895,8 +895,8 @@ def test_ovn_no_compatible_os_release(channel, model):
charm = "ovn-central"
machines = {"0": MagicMock(spec_set=Machine)}
exp_msg = (
f"Channel: {channel} for charm '{charm}' on series 'focal' is currently "
"not supported in this tool. Please take a look at the documentation: "
f"Channel: {channel} for charm '{charm}' on series 'focal' is not supported by COU. "
"Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html "
"to see if you are using the right track."
)
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/apps/test_auxiliary_subordinate.py
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ def test_auxiliary_subordinate_channel_codename_raise(model):
)

exp_msg = (
"Channel: luminous/stable for charm 'ceph-dashboard' on series 'focal' is currently "
"not supported in this tool. Please take a look at the documentation: "
"Channel: luminous/stable for charm 'ceph-dashboard' on series 'focal' is not supported "
"by COU. Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html "
"to see if you are using the right track."
)
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/apps/test_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,8 @@ def test_check_channel_error(_):
channel = "stable"
series = "focal"
exp_error_msg = (
f"Channel: {channel} for charm '{name}' on series '{series}' is currently not supported "
"in this tool. Please take a look at the documentation: "
f"Channel: {channel} for charm '{name}' on series '{series}' is not supported by COU. "
"Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html to see if you "
"are using the right track."
)
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/apps/test_subordinate.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,8 @@ def test_channel_setter_invalid(model, channel):
"""Test unsuccessful validation of channel upgrade plan for SubordinateApplication."""
machines = {"0": MagicMock(spec_set=Machine)}
exp_error_msg = (
f"Channel: {channel} for charm 'keystone-ldap' on series 'focal' is currently not "
"supported in this tool. Please take a look at the documentation: "
f"Channel: {channel} for charm 'keystone-ldap' on series 'focal' is not supported by COU. "
"Please take a look at the documentation: "
"https://docs.openstack.org/charm-guide/latest/project/charm-delivery.html to see if you "
"are using the right track."
)
Expand Down

0 comments on commit dcfd5b4

Please sign in to comment.