- apply suggestions

gabrielcocenza · Apr 23, 2024 · 74aceb6 · 74aceb6
1 parent 361aa41
commit 74aceb6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cou/apps/base.py b/cou/apps/base.py
@@ -369,8 +369,9 @@ async def _verify_workload_upgrade(self, target: OpenStackRelease, units: list[U
 
         if units_not_upgraded:
             raise ApplicationError(
-                f"Cannot upgrade unit(s) '{', '.join(units_not_upgraded)}' to {target}. "
-                "Try again in some minutes to see if the unit(s) have been upgraded."
+                f"Unit(s) '{', '.join(units_not_upgraded)}' did not complete the upgrade to "
+                f"{target}. Some local processes may still be executing; you may try re-running "
+                "COU in a few minutes."
             )
 
     def upgrade_plan_sanity_checks(

diff --git a/tests/unit/apps/test_core.py b/tests/unit/apps/test_core.py
@@ -125,8 +125,8 @@ async def test_application_verify_workload_upgrade_fail(model):
     """Test Kyestone application check unsuccessful upgrade."""
     target = OpenStackRelease("victoria")
     exp_msg = (
-        r"Cannot upgrade unit\(s\) 'keystone/0' to victoria. Try again in some minutes "
-        r"to see if the unit\(s\) have been upgraded."
+        r"Unit\(s\) 'keystone/0' did not complete the upgrade to victoria. Some local processes "
+        r"may still be executing; you may try re-running COU in a few minutes."
     )
     machines = {"0": MagicMock(spec_set=Machine)}
     app = Keystone(