Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test suite on big endian platforms #1001

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix test suite on big endian platforms #1001

wants to merge 1 commit into from

Conversation

maxcrees
Copy link

@maxcrees maxcrees commented Mar 15, 2020 •
edited
Loading

Fixes #897

@maxcrees
Copy link
Author

I forgot endian.h isn't portable so I'll have to take another pass at this at some point.

@JG-Adams
Copy link

Question about this, why would checking endian at compile time address it?
If I compile for big-endian what happens if it run on little-endian?
So we're dealing with bitfield. C++ can't make it work on any system???
I though the issue only arise if you're doing things like reinterpret_cast?
I'm curious about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxcrees @JG-Adams