Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add EIP-1559 #11

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feature: add EIP-1559 #11

merged 2 commits into from
Feb 28, 2024

Conversation

gr8h
Copy link
Collaborator

@gr8h gr8h commented Feb 26, 2024

Changes

Update genesis file for Spark testnet to include configuration for EIP-1559 support.

The transition block is 14707000.

"eip1559Transition": "0xE06938",
"eip1559BaseFeeMaxChangeDenominator": "0x8",
"eip1559ElasticityMultiplier": "0x2",
"eip1559BaseFeeInitialValue": "0x3b9aca00",

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

The implementation of this update was initially conducted on DevNet with the Nethermind client version 1.25.3, where it proceeded smoothly without any complications. Following the upgrade, the network was capable of processing both type 0 and type 2 transactions effectively.

Documentation

eip1559Transition: This parameter specifies the block number at which the EIP-1559 upgrade becomes active.

eip1559BaseFeeMaxChangeDenominator: This parameter controls the maximum rate at which the base fee can change from block to block. The 0x8 value means that the maximum change in the base fee from one block to the next cannot exceed 12.5% (since 1/8 is 0.125 or 12.5%). This rate limits the base fee's volatility.

eip1559ElasticityMultiplier: This parameter determines the maximum gas limit any block can have relative to the target gas limit. The value 0x2 indicates that a block can use up to twice the target gas limit. This elasticity multiplier allows for temporary bursts in network usage, enabling the network to handle sudden increases in demand without significantly delaying transaction processing.

eip1559BaseFeeInitialValue: This parameter sets the initial base fee value right after EIP-1559 is activated.

@gr8h gr8h self-assigned this Feb 26, 2024
@gr8h gr8h merged commit 378a488 into alpha Feb 28, 2024
59 of 61 checks passed
gr8h added a commit that referenced this pull request Mar 24, 2024
Update genesis file for Spark testnet to include configuration for EIP-1559 support.
@gr8h gr8h deleted the feature/eip1559 branch June 25, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants