Upgrade three #53
Open
Upgrade three #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerg
commented
Oct 15, 2017
omerg
commented
- Three.js version upgraded from 0.69 to 0.84
- @types Type Definitions used for three and jquery
- BrowserSync used for reloading page when TypeScript code changed
… sourcemaps are not broken
gruntfile formatted
when upgraded to three version 0.84, three js expects that ground plane is visible so that intersections can be calculated. (See intersectObject method of three.js) when intersection calculation os broken, dragging objects is not possible since mouse and item interaction is impossible to find.
when upgraded to three version 0.84, three js expects that wall planes are visible so that intersections can be calculated. (See intersectObject method of three.js) when intersection calculation os broken, selecting walls is not possible since mouse and item interaction is impossible to find.
chkoniaremi
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.