Changes as requested from Ekki #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ards using 3D with own scenegraph
… creation of walls toggled by bool flag WIP
…eprint3d extension
… concatenated cornerpoint uids ALPHABETICALLY SORTED and then concatenated
…r rendering in different scale via BP3D.Three.CmToWorld (default is 1)
Changes to inject room into foreign scenegraph, more typescript types
…all references into this new example structure to minimise console errors
…ly be selfcontained
…ation of two wallmeshes for each wall without a room
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the fixes as requested from Ekki, based on his fork.
Not done is a default renderer factory, because we need a flag anyhow if the rendererer can be reconfigured by blueprint3d.
The new examples/ folder now houses 3 examples and a shared folder for assets, N.B. defaults in the library (e.g. default floor material) need a changed path, too ..
Every wall can have its own height and thickness to have a selfcontained format. Until now the result depends too much on blueprint3d constants. If not all walls have the same thicknesses, the result is not as pretty as it should be. Not giving (height and thickness) results in the current behaviour.
io/format.ts now houses the file spec for .blueprint3d
Feel free to contact me with comments directly instead of Ekki.
Nils