Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fgpyo.fasta.sequence_dictionary incorrect StrEnum import #175

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Aug 7, 2024

Was getting:
ModuleNotFoundError: No module named 'strenum'

Was getting:
    ModuleNotFoundError: No module named 'strenum'
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (84c8ec4) to head (cfb50d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   89.11%   89.21%   +0.09%     
==========================================
  Files          18       18              
  Lines        2068     2068              
  Branches      457      457              
==========================================
+ Hits         1843     1845       +2     
+ Misses        147      146       -1     
+ Partials       78       77       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 marked this pull request as ready for review August 7, 2024 21:17
@nh13 nh13 requested a review from tfenne as a code owner August 7, 2024 21:17
Copy link
Member

@tfenne tfenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have an fgpyo function like:

is_py_version_at_least("3.11")

that can have tests, and then use it here?

@nh13 nh13 merged commit 29b20c9 into main Aug 8, 2024
8 checks passed
@nh13 nh13 deleted the fix/strenum branch August 8, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants