Mymaster enhanced icons #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code cleanup
Added a "Draw Mode Settings" entry in View menu. It is enabled if settings are available for the current draw mode.
Added a "Draw Mode Settings" entry in View menu. It is enabled if settings are available for the current draw mode.
…nd down keys. Added : A : Toggle Draw axes S : Take Screenshot Up : Use next shader Down : use previous shader Modified : M : Toggle Menu (was Ctrl Shift C) F : Toggle Fullscreen (was F11)
Add some action in the window widget so the shortcuts will be available even when the menu bar is hidden.
The toolbar is toggled with the menu.
Usefull to save given size screenshots.
…edges and allow drawing wireframe in the meshlight shader. Minor modifications to the other shaders and use version 330
…n 330 in which case drawing wireframe on top of the meshlight shader is not available.
…sion as nividia for example will have something like 4.60 NVIDIA and the toDouble conversion will result in 0
version 330 shaders and fallback if not successful
…ntu 20.04 and add a conditional compilation for obsolete method.
|
Thank you for proposing this, but as you speculated, this PR is a bit too large to merge. If you want to propose PRs for individual features that is more feasible IMO. I think I'd like to create a shortcut system as well as a shader plugin system which will address some of the features you have included in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this pull request might be a little too much to be accepted ;-). By the way, it contains the pending #101 (which adresses #40) and #102 .
This also adresses #74.
This is my current version, and the way I like to use it. It is available as an ubuntu package
fstl-eunder ppa:wdaniau/custom . An AppImage and a Windows binary can also be found in the releases on my github fork.I have added a toolbar as I usually find this easier to use than searching the menus.
I also changed all the shortcuts to simple "one key" shortcuts :
Q : Quit
O : Open
R : Reload
P : Draw Mode Settings (P comes from Preferences)
A : Draw Axes
M : Show/Hide Menu (and Toolbar as well)
S : Save Screenshot
F : Toggle Fullscreen
W : Toggle wireframe on top of new shader (see below)
Left : load previous stl file
Right : load next stl file
Up : Use next shader
Down : Use previous shader
( The last two adresses #89 )
I also added a menu with some predefined viewport sizes to help saving screenshots of a given size.
Also added an option in the new shader to draw wireframe on top of it ( adresses #95 ).
Save and restore hide menu state ( adresses #90 )
Will.