Make S3FileSystem.protocol type tuple[str, ...] #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine for now, thank you. In the future, we should probably make more tests in https://github.com/fsspec/filesystem_spec/tree/master/fsspec/tests/abstract that ensure the spec is followed for all implementations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR makes
S3FileSystemmore spec compliant by changing the protocol type fromlist[str]totuple[str, ...]as required by fsspec:https://github.com/fsspec/filesystem_spec/blob/6aa8a9a888f8d7ce2c721f6896f1ffabde84ef05/fsspec/spec.py#L107
This caused an issue when I was using s3fs together with ReferenceFileSystem. See fsspec/filesystem_spec#1395
Let me know if I should also add some sort of test to ensure the protocol type.
Cheers,
Andreas