Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cache_regions to True by default #715

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

martindurant
Copy link
Member

This seems to solve a number of aiobotocore redirect access issues, and aside from complexity, I don't see a downside.

@martindurant
Copy link
Member Author

martindurant commented Mar 28, 2023

cc @Eugeny

One small caveat I have here, is the possibility of HEAD_BUCKET failing. I recebntly discovered that the following always succeeds (could be aiohttp rather than requests):

requests.head(f"https://{bucket}.s3.amazonaws.com").headers["x-amz-bucket-region"]

Do you think we should switch to this simpler form? It should be faster too, since it involves no auth.

Another specific thing that occurred to me: we should never use region caching together with endpoint_url, right?

@martindurant
Copy link
Member Author

(cc @efiop , if interested)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant