fix: raise error when listing empty dir

fsspec · Aug 16, 2023 · 27a4085 · 27a4085
1 parent 7a63104
commit 27a4085
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/s3fs/core.py b/s3fs/core.py
@@ -969,6 +969,8 @@ async def _ls(self, path, detail=False, refresh=False, versions=False):
                     for o in files
                     if o["name"].rstrip("/") == path and o["type"] != "directory"
                 ]
+                if not files:
+                    raise FileNotFoundError(path)
             if detail:
                 return files
         return files if detail else sorted([o["name"] for o in files])

diff --git a/s3fs/tests/test_s3fs.py b/s3fs/tests/test_s3fs.py
@@ -281,7 +281,8 @@ def test_info(s3):
     s3.mkdir(new_parent)
     with pytest.raises(FileNotFoundError):
         s3.info(new_parent)
-    s3.ls(new_parent)
+    with pytest.raises(FileNotFoundError):
+        s3.ls(new_parent)
     with pytest.raises(FileNotFoundError):
         s3.info(new_parent)