Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle shuffle twice #383

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

martindurant
Copy link
Member

Fix #382

@rabernat
Copy link
Contributor

We'd love to help add a test against #382. Any advice on where to start?

@martindurant
Copy link
Member Author

We'd love to help add a test against #382

I ran against your file, of course.

For a test in CI, you could resurrect #274, and build in some of these various compression/shuffle/encoding options. I don't really know how to make hdf files which would exercise all of the code paths in SingleHdf5ToZarr .

@martindurant
Copy link
Member Author

But OK to merge and quick release here?

@rabernat
Copy link
Contributor

Sure, we appreciate the quick fix! 🙏

We'll think about how to address the testing question, which is needed in order to guard against the same problem happening in the future.

@martindurant martindurant merged commit cdd106b into fsspec:main Oct 25, 2023
5 checks passed
@martindurant martindurant deleted the shuffle_back branch October 25, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.2.1 broke existing workflows - 'SingleHdf5ToZarr' object has no attribute 'decoders'
2 participants