localfs: reduce stat calls during info #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For symlinks, `LocalFileSystem.info()` was making 3 stat calls, first for the symlink file itself, second for the link target, and third to get `size` information of the link target. This is wasteful, and `size` can be gathered from `stat` of the link target.
skshetry
changed the title
skshetry
added a commit
to iterative/dvc-data
that referenced
this pull request
Aug 12, 2024
Reduces no. of stat calls and avoids _strip_protocol call which is slow when we have large no. of files. For reducing stat calls upstream, I have a PR in fsspec/filesystem_spec#1659.
skshetry
added a commit
to iterative/dvc-data
that referenced
this pull request
Aug 12, 2024
Reduces no. of stat calls and avoids _strip_protocol call which is slow when we have large no. of files. For reducing stat calls upstream, I have a PR in fsspec/filesystem_spec#1659.
skshetry
added a commit
to iterative/dvc-data
that referenced
this pull request
Aug 12, 2024
optimize localfs.info Reduces no. of stat calls and avoids _strip_protocol call which is slow when we have large no. of files. For reducing stat calls upstream, I have a PR in fsspec/filesystem_spec#1659.
skshetry
added a commit
to iterative/dvc-data
that referenced
this pull request
Aug 12, 2024
optimize localfs.info Reduces no. of stat calls and avoids _strip_protocol call which is slow when we have large no. of files. For reducing stat calls upstream, I have a PR in fsspec/filesystem_spec#1659.
| "type": t, | ||
| "created": out.st_ctime, | ||
| "islink": link, | ||
| } | ||
| for field in ["mode", "uid", "gid", "mtime", "ino", "nlink"]: | ||
| result[field] = getattr(out, f"st_{field}") | ||
| if result["islink"]: | ||
| if link: | ||
| result["destination"] = os.readlink(path) |
There was a problem hiding this comment.
Since we are doing micro-optimisation, might the destination path also be known?
There was a problem hiding this comment.
I don't think there is a way to get destination path without doing a readlink. stat struct does not have a path or a target path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For symlinks,
LocalFileSystem.info()was making 3 stat calls, first for the symlink file itself, second for the link target, and third to getsizeinformation of the link target.This is wasteful, and
sizecan be gathered fromstatof the link target.