Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't drop paths containts globs #305

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Antaxify
Copy link

@Antaxify Antaxify commented Apr 5, 2022

This PR contains the following changes:

  • fixed the list comprehension in _expand_path to not drop glob paths (foo/bar/*)
  • fixed _expand_path when called with a glob path and recursive=True
  • fixed _glob_find when called with a glob path
  • added a test to map the current behavior of expand_path (recursive=True)
  • fix _put_file when called with a path that is a directory

Please let me know what you think about these changes.

I noticed that _glob_find and _find are not consistent when returning directory paths. _find returns trailing slashes while _glob_find does not. Is that intended?

Also in the current implementation _expand_path includes the root directory for non-glob paths, while _glob_find does not. What is the desired behavior here?

About tests:

  • test_url failed for me with a 403 before my changes - did not look into that
  • I don't know why the CI tests are failing - I guess this is a general issue?

@Antaxify Antaxify closed this Apr 5, 2022
@Antaxify Antaxify reopened this Apr 6, 2022
@Antaxify Antaxify force-pushed the fix-expand-paths-using-globs branch from 764ee4e to 6759a3f Compare April 6, 2022 08:50
@Antaxify Antaxify force-pushed the fix-expand-paths-using-globs branch from 6759a3f to d7d5a16 Compare April 6, 2022 10:11
@hayesgb
Copy link
Collaborator

hayesgb commented Apr 9, 2022

Thanks for digging in here.

CI tests run against Azurite, which Microsoft updated 6 weeks ago. I'll dig into this failure mode, then I'll circle back to the question of other topics.

@Antaxify
Copy link
Author

Any update on this?

@Antaxify
Copy link
Author

@hayesgb did you find time to look into this?

@Antaxify
Copy link
Author

Antaxify commented Jul 7, 2022

Anything I can do to get this merged?

@hfurkanvural
Copy link
Contributor

Any update or progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants