-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't drop paths containts globs #305
Open
Antaxify
wants to merge
6
commits into
fsspec:main
Choose a base branch
from
Antaxify:fix-expand-paths-using-globs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antaxify
force-pushed
the
fix-expand-paths-using-globs
branch
from
April 6, 2022 08:50
764ee4e
to
6759a3f
Compare
Antaxify
force-pushed
the
fix-expand-paths-using-globs
branch
from
April 6, 2022 10:11
6759a3f
to
d7d5a16
Compare
Thanks for digging in here. CI tests run against Azurite, which Microsoft updated 6 weeks ago. I'll dig into this failure mode, then I'll circle back to the question of other topics. |
Any update on this? |
@hayesgb did you find time to look into this? |
Anything I can do to get this merged? |
Any update or progress on this? |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Please let me know what you think about these changes.
I noticed that _glob_find and _find are not consistent when returning directory paths. _find returns trailing slashes while _glob_find does not. Is that intended?
Also in the current implementation _expand_path includes the root directory for non-glob paths, while _glob_find does not. What is the desired behavior here?
About tests: