-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup code inspections / xmldoc rendering #222
Conversation
EDIT: the below may not matter much after I found out that using Original post:
Ehm, you mean to not use
but the
Indeed, so we shouldn't drop Granted, I may not get your point here, really 😆. Related, this discussion shows that I'll write something up to figure this out conclusively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go, once the changes are applied. Great work!!!
0b7b537
to
b592879
Compare
I've taken the liberty to squash these commits a bit, and fixed some small errors in xml doc tags, plus removed some "legalese" wording 😆. I think it is good to be merged now. The |
Yes all these cleanup ones I'd prefer them to be squash merged (I'm a fan of the linear history tickbox) |
b592879
to
1023dbd
Compare
Yeah, that's not supported on this repo, I do like to see informed and well-written commits. Squash-merging defeats that purpose. But I do keep a linear history, and require rebasing. |
Calved from #220: small cleanups per Rider suggestions, and adding dictionary entries covering terms used in the repo.
Also:
new
on theIAsyncDisposable
being redundant. In this instance, I think the most direct thing to resolve it is to just not do that - theDispose
impl is not doing Async things. But, as we discussed, it's bad news that the tooling is suggesting dropping thenew
/ not making the fact it's a disposable stick out.new
for IAsyncDisposable construction JetBrains/resharper-fsharp#589 requested Rider to not suggest removingparamref
s that are not correct (dont reference actual things), but we are using them here as its the only way to have VS+VSCode highlight types or snippets in bold (and Rider does not render<c>
in bold either)