Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add style for php 'blade' templates #573

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raboof
Copy link
Contributor

@raboof raboof commented Aug 20, 2022

No description provided.

@mxmehl mxmehl added the comment-styles Request for a new comment style, or fixing a bug with these label Aug 31, 2022
@nicorikken
Copy link
Member

Thanks @raboof! I'm afraid we will encounter more double extensions in the future and then this might be helpful. Do you have some examples for that comment style, ideally where a license header is used?

I think the plural array name is confusing. How about renaming EXTENSIONS_COMMENT_STYLE_MAP_LOWERCASE to MULTIPLE_EXTENSION_COMMENT_STYLE_MAP_LOWERCASE It is longer of course.

Also I think this needs a test to check precedence to avoid breaking things when refactoring in the future.

@raboof
Copy link
Contributor Author

raboof commented Nov 9, 2022

Do you have some examples for that comment style, ideally where a license header is used?

Yes, at https://codeberg.org/eicas/website/src/branch/add-mit-license/resources/views/home.blade.php

I think the plural array name is confusing. How about renaming EXTENSIONS_COMMENT_STYLE_MAP_LOWERCASE to MULTIPLE_EXTENSION_COMMENT_STYLE_MAP_LOWERCASE It is longer of course.

Sure

Also I think this needs a test to check precedence to avoid breaking things when refactoring in the future.

Makes sense. Fair warning: I might not get to this soon, though.

@mxmehl mxmehl changed the title Add style for php 'blade' templates WIP: Add style for php 'blade' templates Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comment-styles Request for a new comment style, or fixing a bug with these
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants