Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make poetry.lock uncommentable #1037

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Jul 5, 2024

Fixes #1035

  • Added a change log entry in changelog.d/<directory>/.
  • Added self to AUTHORS.rst.
  • I agree to license my contribution under the licenses indicated in the
    changed files.

mxmehl
mxmehl previously requested changes Jul 8, 2024
Copy link
Member

@mxmehl mxmehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM in principle, but the ordering was wrong.

Regarding the changelog entry, Carmen should have another look, not sure with the new changelog system.

src/reuse/comment.py Outdated Show resolved Hide resolved
@carmenbianca
Copy link
Member

Merging, thank you @Mersho!

@carmenbianca carmenbianca requested a review from mxmehl July 8, 2024 08:41
@carmenbianca carmenbianca merged commit 6fff10c into fsfe:main Jul 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add poetry.lock to uncommentable files
3 participants