-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rdbms matrix for wider compatibility testing #196
base: 0.7.x
Are you sure you want to change the base?
Add rdbms matrix for wider compatibility testing #196
Conversation
3d2d16b
to
b9f6703
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach, but I'm not sure if we should add this to the same MySQL job here. You suggested to test this with mariadb:10
across all supported PHP versions, but I don't think this is necessary here. Looking further, if we want to support additional databases in different versions, this would result in a huge (and completely confusing) test matrix in GitHub actions.
I think we should test mysql
across all supported PHP versions, but for mariadb
we could also test against the latest PHP version(s) in a different job to avoid overloading this.
What do you think?
We could introduce MariaDB in a follow up PR.
Givin that MariaDB is a fork by the creator on MySQL, we could flip a could and prefer one of them?
To be brutally honest: Test all permutations; but that is a personal preference that I enforce in my own packages and projects, so I'll make the adjustment for this PR. |
This change set introduces a `rdbms` matrix with the purpose of increasing insurance this package works with up to the latest MySQL/MariaDB versions. Note that due to MySQL's versioning there are no `v6` and `v7`. Refs: friends-of-reactphp#194
b9f6703
to
249c5fe
Compare
@SimonFrings Pushed the changes |
This change set introduces a
rdbms
matrix with the purpose of increasing insurance this package works with up to the latest MySQL/MariaDB versions.Note that due to MySQL's versioning there are no
v6
andv7
.Refs: #194