Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the
React\MySQL
namespace toReact\Mysql
without any additional code adjustments.Both options are valid when it comes to PSR-4. The specification describes the use of alphabetic characters like this:
Changing the namespace to
React\Mysql
aligns with recent changes made in #186 and #187, where we added aMysql
prefix to name theMysqlClient
andMysqlResult
. This means my suggested PR improves the consistency when it comes to naming our namespace, classes, and variables.Considering that
v0.7.x
already includes BC-Breaks from #186 and #187, it could be a perfect time to introduce this additional BC-Break as well.I'm interested in your thoughts on this 👍