Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MySQL namespace to Mysql #188

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

SimonFrings
Copy link
Contributor

This pull request changes the React\MySQL namespace to React\Mysql without any additional code adjustments.

Both options are valid when it comes to PSR-4. The specification describes the use of alphabetic characters like this:

Alphabetic characters in the fully qualified class name MAY be any combination of lower case and upper case.

Changing the namespace to React\Mysql aligns with recent changes made in #186 and #187, where we added a Mysql prefix to name the MysqlClient and MysqlResult. This means my suggested PR improves the consistency when it comes to naming our namespace, classes, and variables.

Considering that v0.7.x already includes BC-Breaks from #186 and #187, it could be a perfect time to introduce this additional BC-Break as well.

I'm interested in your thoughts on this 👍

Copy link
Contributor

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for looking into this!

I agree typing the FQCN …\MySQL\Mysql… is somewhat awkward and using the name MySQLClient in #186/#147 didn't really feel like an option either, so it probably makes sense to consistently go with the Mysql casing also for the classname 👍

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm interested in your thoughts on this 👍

Meh but consistency is more important IMHO

@WyriHaximus WyriHaximus merged commit 228bedd into friends-of-reactphp:0.7.x Nov 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants