Randomize ports #95
Draft
Randomize ports #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bootstrap page will need to determine the fproxy port. It can be handled as a query string. |
ArneBab
reviewed
Apr 8, 2022
| } | ||
|
|
||
| // instantiate connector with given port | ||
| Connector connector = new Connector("127.0.0.1", prefs.getInt("fcp.port", 9481)); |
There was a problem hiding this comment.
no randomized IP? 127.x.y.z should be possible.
ArneBab
reviewed
Apr 8, 2022
| // store in shared preferences | ||
| SharedPreferences.Editor editor = prefs.edit(); | ||
| editor.putInt("fproxy.port", new Random().nextInt(TOP_RANGE - BOTTOM_RANGE) + BOTTOM_RANGE); | ||
| editor.putInt("fcp.port", new Random().nextInt(TOP_RANGE - BOTTOM_RANGE) + BOTTOM_RANGE); |
|
@desyncr Did you see the reviews here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to randomize fproxy.port and fcp.port configs at first run.
Closes #77