Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): Enhance banners with updated content #394

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Sep 11, 2024

This PR removes the banner from the login page and updates the banner within the options page to inform users about the code upgrade to Manifest Version 3. Additionally, it updates the badge icon style to use a number instead of the bell emoji for Firefox and Chrome.

Here are screenshots showing the banner and the badge icon:

image


image


Screen Recording 2024-09-11 at 5 07 20 PM

@ERosendo ERosendo added the no changelog Override Check Changelog Action. label Sep 11, 2024
@ERosendo ERosendo marked this pull request as ready for review September 11, 2024 21:11
Copy link
Member

@mlissner mlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but don't we need to reset the cookie or something so that it shows up when the new version is installed?

@ERosendo
Copy link
Contributor Author

don't we need to reset the cookie or something so that it shows up when the new version is installed?

@mlissner You're right! I've addressed this issue by replacing the existing flag in localStorage with a new one that ensures the banner is displayed upon installation.

@mlissner mlissner merged commit 5cc7cf4 into main Sep 11, 2024
8 checks passed
@mlissner mlissner deleted the feat-update-recap-banners branch September 11, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Override Check Changelog Action.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants