Fix setDefaultOptions in updateToolbarButton

freelawproject · Oct 3, 2024 · 8f5064a · 8f5064a
1 parent b714080
commit 8f5064a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -5,7 +5,7 @@
 The following changes are not yet released, but are code complete:
 
 Features:
- - None yet
+ - Fix setDefaultOptions in updateToolbarButton([403](https://github.com/freelawproject/recap-chrome/pull/403))
 
 Changes:
  - Upgrade to CourtListener v4 API([380](https://github.com/freelawproject/recap/issues/380), [401](https://github.com/freelawproject/recap-chrome/pull/401))

diff --git a/src/utils/toolbar_button.js b/src/utils/toolbar_button.js
@@ -31,6 +31,13 @@ export function updateToolbarButton(tab) {
   };
 
   chrome.storage.local.get('options', function (items) {
+    if (!Object.keys(items).length) {
+      // Firefox 56 bug. The default settings didn't get created properly when
+      // upgrading from the legacy extension. This can be removed when everybody
+      // is safely beyond 56 (and the ESR)
+      setDefaultOptions({});
+    }
+
     if (
       'dismiss_news_badge' in items['options'] &&
       items['options']['dismiss_news_badge']
@@ -52,12 +59,6 @@ export function updateToolbarButton(tab) {
       });
       return;
     }
-    if (!Object.keys(items).length) {
-      // Firefox 56 bug. The default settings didn't get created properly when
-      // upgrading from the legacy extension. This can be removed when everybody
-      // is safely beyond 56 (and the ESR)
-      setDefaultOptions({});
-    }
 
     if (items && items['options'] && !items['options']['recap_enabled']) {
       setTitleIcon('RECAP is temporarily disabled', {