Merge pull request #338 from freelawproject/fix-free-docs-upload-from…

…-appellate

fix(appellate): Remove the logic to normalize the pacer_dls_id

CHANGES.md

@@ -13,6 +13,7 @@ Changes:
 Fixes:
  - More robust logic to get the document id from appellate courts([#340](https://github.com/freelawproject/recap/issues/340))
  - Normalize document numbers from appellate courts that uses the pacer_doc_id instead of the regular docket entry numbering([#2877](https://github.com/freelawproject/courtlistener/issues/2877)).
+ - Remove logic to normalize the pacer_dls_id attribute in the document links([#338](https://github.com/freelawproject/recap-chrome/pull/338))
 
 For developers:
  - Nothing yet

spec/AppellateSpec.js

@@ -11,10 +11,12 @@ describe('The Appellate module', function () {
     {
       href: 'https://ecf.ca9.uscourts.gov/docs1/009031927529',
       onClick: "return doDocPostURL('009031927529','290338');",
+      dlsId: '009031927529',
     },
     {
       href: 'https://ecf.ca9.uscourts.gov/docs1/009131956734',
       onClick: "return doDocPostURL('009131956734','290338');",
+      dlsId: '009131956734',
     },
   ];
   const searchParamsWithCaseId = new URLSearchParams('servlet=DocketReportFilter.jsp&caseId=318547');
@@ -50,10 +52,9 @@ describe('The Appellate module', function () {
   describe('getDocIdFromURL', function () {
     it('returns the document id ', function () {
       for (const item of showDocURLs) {
-        var queryString = new URLSearchParams(item.url)
+        var queryString = new URLSearchParams(item.url);
         expect(APPELLATE.getDocIdFromURL(queryString)).toBe(item.docId);
       }
-
     });
   });
 
@@ -233,7 +234,7 @@ describe('The Appellate module', function () {
 
           for (let i = 0; i < anchors.length; i++) {
             let item = anchors[i];
-            expect(item.dataset.pacerDlsId).toBe(links[i]);
+            expect(item.dataset.pacerDlsId).toBe(documentLinks[i]['dlsId']);
             expect(item.dataset.pacerCaseId).toBe('290338');
             expect(item.dataset.pacerTabId).toBe('3');
             expect(item.dataset.attachmentNumber).toBe('0');

src/appellate/utils.js

@@ -280,7 +280,8 @@ let APPELLATE = {
 
       clonedNode.dataset.pacerDocId = docId;
       if (doDoc && doDoc.doc_id) {
-        clonedNode.dataset.pacerDlsId = PACER.cleanPacerDocId(doDoc.doc_id);
+        // don't normalize this attribute because we use it to check whether a doc is free or not
+        clonedNode.dataset.pacerDlsId = doDoc.doc_id;
       }
       clonedNode.dataset.pacerCaseId = pacerCaseId;
       clonedNode.dataset.pacerTabId = tabId;