fix(coloctapp): update cleanup_content #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves: #1215 We are getting duplicate hashes again due to some documents having multiple hash altering elements. Generalize cleanup_content to cases with more than one element
grossir
force-pushed
the
clean_coloctapp_content
branch
from
55bceb2
to
aa5f1bd
Compare
flooie
reviewed
Oct 21, 2024
|
|
||
| for tag in tree.xpath("//*[@class]"): | ||
| tag.attrib.pop("class") | ||
| remove_tags = ["//style", "//img"] |
There was a problem hiding this comment.
Instead of doing this - perhaps we should modify
from juriscraper.lib.html_utils import strip_bad_html_tags_insecure
or some similar function to pass in extra tags we want to remove using Nh3 ?
flooie
reviewed
Oct 21, 2024
Comment on lines
+40
to
+47
| remove_tags = ["//style", "//img"] | ||
| remove_attributes = [ | ||
| "//*[@class]", | ||
| # contains json like data with "ctm" key | ||
| "//*[@data-data]", | ||
| # contains coordinate like data | ||
| "//*[@data-dest-detail]", | ||
| ] |
There was a problem hiding this comment.
is it possible we might want to leave some of these classes in so we can use them to improve how tresults display on CL
There was a problem hiding this comment.
Im starting to think we should look at the few HTML scrapers and tailor some CSS for them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
#1215
We are getting duplicate hashes again due to some documents having multiple hash altering elements. Generalize cleanup_content to cases with more than one element