feat(lactapp_1): dynamic backscraper #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will help solve #1194 - create utils method `backscrape_over_paginated_results`, abstracted from nd - refactor `nd` to use it - refactor `lactapp_1` to use it
|
You can test that both are still working by doing: |
|
why not just use each date instead of paginating? |
|
using each date means a request per each day in the interval, since we don't know exactly when an opinion was published; a single pagination request covers many days. I think that except for very small intervals, the pagination will make less requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help solve #1194
backscrape_over_paginated_results, abstracted from ndndto use itlactapp_1to use it