Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Active users][Settings][Account settings] Add functionality for Text inputs #136

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

carma12
Copy link
Collaborator

@carma12 carma12 commented Aug 22, 2023

The following fields have been adapted to use the IpaTextInput component:

  • 'User login' (uid)
  • 'Password' (has_password)
  • 'Password expiration' (krbpasswordexpiration)
  • 'UID' (uidnumber)
  • 'GID' (gidnumber)
  • 'Login shell' (loginshell)
  • 'Home directory' (homedirectory)
  • 'Radius proxy username' (ipatokenradiususername)
  • 'External IdP user identifier' (ipaidpsub)

@carma12 carma12 requested a review from pvoborni August 22, 2023 11:15
Copy link
Member

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments. I'm not sure if to approve or not due to the has_password issue.

The following fields need to be adapted to use
the `IpaTextInput` component:
- 'User login' (`uid`)
- 'Password' (`has_password`)
- 'Password expiration' (`krbpasswordexpiration`)
- 'UID' (`uidnumber`)
- 'GID' (`gidnumber`)
- 'Login shell' (`loginshell`)
- 'Home directory' (`homedirectory`)
- 'Radius proxy username' (`ipatokenradiususername`)
- 'External IdP user identifier' (`ipaidpsub`)

Signed-off-by: Carla Martinez <[email protected]>
Copy link
Member

@pvoborni pvoborni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carma12 carma12 merged commit dfc98d5 into freeipa:main Aug 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants