Fix autocleaner #424
Merged
Fix autocleaner #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The autocleaner.py is executed by cron which sets path to PATH=/usr/bin:/bin. As exportfs is in /usr/sbin it must have full path specified, otherwise the script is crashing and fails to clean up old jobs directories Fixes freeipa#422
The condition was always true because file mtime is less then current time and "mtime - now" is negative.
netoarmando
approved these changes
Mar 4, 2021
|
Deployed to all runners. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing two issues in autocleaner.py:
--jobs_dir_expoption was not respected, all jobs dirs were removed