Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hbacsvcgroup: Remove obsolete result_handler #1156

Conversation

t-woerner
Copy link
Member

The result_handler is not needed anymore as the idempotency issues with members have been fixed already for this module.

Related: #685 hbacsvcgroup: Fix member management idempotence issues.

@t-woerner t-woerner force-pushed the hbacsvcgroup_remove_oobsolete_result_handler branch from fd4981e to 4a64af3 Compare October 12, 2023 11:55
@t-woerner t-woerner changed the title bacsvcgroup: Remove obsolete result_handler hbacsvcgroup: Remove obsolete result_handler Oct 12, 2023
Copy link
Member

@rjeffman rjeffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(But let's try to have CI running again before merging.)

@t-woerner t-woerner force-pushed the hbacsvcgroup_remove_oobsolete_result_handler branch from 4a64af3 to c9203da Compare October 19, 2023 11:36
The result_handler is not needed anymore as the idempotency issues with
members have been fixed already for this module.

Related: freeipa#685 hbacsvcgroup: Fix member management idempotence issues.
@t-woerner t-woerner force-pushed the hbacsvcgroup_remove_oobsolete_result_handler branch from c9203da to 3de6f91 Compare October 20, 2023 23:09
@rjeffman rjeffman merged commit 1dbe19c into freeipa:master Oct 23, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants