Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused setuptools-requirements.txt #7214

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Remove unused setuptools-requirements.txt #7214

merged 1 commit into from
Aug 14, 2024

Conversation

legoktm
Copy link
Member

@legoktm legoktm commented Aug 7, 2024

Status

Ready for review

Description of Changes

I couldn't easily spot when this became unused, but its functionality has been replaced by bootstrap-requirements.txt.

Testing

  • CI passes
  • rg setuptools-requirements turns up no hits

Deployment

Any special considerations for deployment? Seems like a no-op.

Checklist

  • Linting (make lint) and tests (make test) pass in the development container
  • Linting and tests (make -C admin test) pass in the admin development container

I couldn't easily spot when this became unused, but its functionality
has been replaced by bootstrap-requirements.txt.
@legoktm legoktm requested a review from a team as a code owner August 7, 2024 15:05
@cfm cfm self-assigned this Aug 14, 2024
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a binary search through the Git history and couldn't find this used anywhere either. Nice catch, @legoktm.

@cfm cfm merged commit e019007 into develop Aug 14, 2024
17 checks passed
@legoktm legoktm deleted the unused-setuptools branch August 15, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants