Enable deprecated docker pull functionalty to fix nightlies. #7196
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legoktm
added a commit
that referenced
this pull request
Aug 13, 2024
We have not updated our gcloud-sdk image since 2018 and it's really not worth us maintaining this when Google provides its own image. We now authenticate using the method documented at <https://cloud.google.com/sdk/docs/downloads-docker>, in which we invoke the container to login, which creates a volume that can be used in future calls. This means we no longer need to have a running container that we exec into; we can just create a new container each time we want to make a gcloud call. Fixes #7195. Fixes #7196.
5 tasks
legoktm
added a commit
that referenced
this pull request
Aug 15, 2024
We have not updated our gcloud-sdk image since 2018 and it's really not worth us maintaining this when Google provides its own image. We now authenticate using the method documented at <https://cloud.google.com/sdk/docs/downloads-docker>, in which we invoke the container to login, which creates a volume that can be used in future calls. This means we no longer need to have a running container that we exec into; we can just create a new container each time we want to make a gcloud call. Fixes #7195. Fixes #7196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
RfR
Description of Changes
Fixes #7195 .
staging-tests-with rebaseCI job, run both nightly and for branches prefixed withstg-Testing
staging-test-with-rebaseDeployment
n/a - CI only.