Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jinja2 in admin and dev reqs, use latest semgrep in CI #7109

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Jan 24, 2024

Status

Ready for review

Description of Changes

  • Updates jinja2 to 3.1.3 in admin and development requirements.
  • Reverts to using latest semgrep in CI.

Testing

  • CI looks good
  • prod deps not updated.

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner January 24, 2024 19:42
@cfm cfm self-assigned this Jan 24, 2024
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI looks good
  • prod deps not updated.

Nit:

admin/requirements-ansible.in lists production dependencies per

Production code dependencies are defined in:
- `admin/requirements.in`
- `admin/requirements-ansible.in`
—but that's okay in this case, since the diff review happened in #7107. :-)

@cfm cfm merged commit 7eab3b8 into develop Jan 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants