Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create 2.7.0-rc2 version #7018

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Create 2.7.0-rc2 version #7018

merged 1 commit into from
Oct 19, 2023

Conversation

zenmonkeykstop
Copy link
Contributor

@zenmonkeykstop zenmonkeykstop commented Oct 19, 2023 •
edited by cfm
Loading

Status

Ready for review

Description of Changes

Towards #6979.

Changes proposed in this pull request:

Testing

  • changelog update is consistent
  • CI is passing
  • PR base is release/2.7.0
  • version updated correctly.

@zenmonkeykstop zenmonkeykstop requested a review from a team as a code owner October 19, 2023 22:36
@zenmonkeykstop zenmonkeykstop changed the base branch from develop to release/2.7.0 October 19, 2023 22:36
@cfm cfm self-assigned this Oct 19, 2023
cfm
cfm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending CI. Nits are optional; I won't be offended if you don't feel like restarting the CI clock for them. :-)

changelog.md

### Web applications

* Update translation workflow to support continuous updates (#7010)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit (original #7008 → backport #7010):

Suggested change
* Update translation workflow to support continuous updates (#7010)
* Update CI logic for continuous localization (#7010)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're grouping all those in the final changelog, I'm just using the same text for now while making it clear which pr went in which release.

changelog.md

### Operations

* Use systemd timers to check for disconnected submissions and source listings (#7009)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit: original #7009 → backport #7015.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general IMO it's more useful to reference the original PR rather than the backport.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; that's why I flagged #7018 (comment).

Copy link
Contributor Author

@zenmonkeykstop zenmonkeykstop Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d'oh - we'll fix it in post 🎥

cfm
cfm approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Troubleshot out of band: app-tests and app-page-layout-tests are passing, but uploader.codecov.io is flapping between previous version 0.7.0 and new version 0.7.1. I'm comfortable approving this as it is; your merge as Release Manager, @zenmonkeykstop.

@zenmonkeykstop zenmonkeykstop merged commit 63bd1a7 into release/2.7.0 Oct 19, 2023
10 of 12 checks passed
@cfm cfm mentioned this pull request Oct 26, 2023
Closed
@zenmonkeykstop zenmonkeykstop deleted the bump-2.7.0rc-fun branch November 2, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfm cfm cfm approved these changes

Assignees

@cfm cfm

Labels
None yet
Projects
SecureDrop dev cycle
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenmonkeykstop @cfm