Do not include config.py in built packages #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like the custom_logo.png, we don't want to package config.py if it exists. The absence of config.py is already verified by test_securedrop_deb_package.py, but now you won't have to rebuild your packages since it won't be included at all. Fixes #6973.
zenmonkeykstop
approved these changes
Oct 19, 2023
|
(IMO we can get away without backporting this into the in-flight release as it will get caught by a test anyway...) |
|
Agreed, and real builds should be done from a fresh/clean git checkout so no config.py should exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
Just like the custom_logo.png, we don't want to package config.py if it exists.
The absence of config.py is already verified by
test_securedrop_deb_package.py, but now you won't have to rebuild your packages since it won't be included at all.
Fixes #6973.
Testing
make securedrop/config.pymake build-debsDeployment
Any special considerations for deployment? No
Checklist