Skip to content

Commit

Permalink
fix(check-desktop-strings): enforce forward compatibility with gettex…
Browse files Browse the repository at this point in the history
…t 0.21 behavior

Fixes #7007.  Beginning in gettext 0.21---specifically, as of
autotools-mirror/gettext@1c9b721---xgettext and (of interest to us)
msgfmt do not localize the "Icon" keyword.  That's fine, indeed
preferable, for our purposes.  But since Ubuntu Focal only has gettext
0.19, where they do, we need to pass an explicit "--keyword=Name" here
to get consistent output across platforms.

(cherry picked from commit 2e6b905)
  • Loading branch information
cfm authored and legoktm committed Oct 16, 2023
1 parent 3cf5f4a commit fd1905f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,7 @@ $(DESKTOP_POT): ${DESKTOP_BASE}/*.in
@msgfmt \
-d ${DESKTOP_LOCALE_DIR} \
--desktop \
--keyword=Name \
--template $< \
--output-file $@
@rm ${DESKTOP_LOCALE_DIR}/*.po
Expand Down

0 comments on commit fd1905f

Please sign in to comment.