This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
Implement proxy v2 architecture, in Rust #127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kunal Mehta <[email protected]>
Co-authored-by: Kunal Mehta <[email protected]>
We care about the preservation of the entire configured origin tuple (scheme, host, port), not just the hostname.[1] However, there is a tension in considering whether this check is valuable: 1. On the one hand, as @legoktm has pointed out, if Url::parse() is compromised, why should we trust the result of Url::Url.origin()? 2. On the other hand, as Daniel Stenberg has documented, "mixing parsers is considered a security risk".[2] [1]: https://url.spec.whatwg.org/#origin [2]: https://daniel.haxx.se/blog/2022/01/10/dont-mix-url-parsers/
`process::exit()` immediately terminates with the given exit code, meaning that no destructors are run. For our purposes it shouldn't matter much, but let's exit the graceful way.
Rewrite the existing tests to be integration tests against a compiled Rust binary. We use the httpbin library to start up a Python webserver and instruct the proxy to connect to it. This allows to test connection properties that aren't recordable in the VCR format, like timeouts or streamed responses. The tests are reorganized to be split into proxy handling and error handling.
And remove the Python CI. We still need to set up cargo-audit and cargo-vet jobs.
|
dca4722^...61305c will need revising based on freedomofpress/securedrop-engineering#82. I'll be happy to do that once that's approved and this is stable. |
16 tasks
|
I've migrated this to freedomofpress/securedrop-client#1718. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placeholder, details TK.
Refs freedomofpress/securedrop-client#1678.