Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #468
This replaces our use of
pip-compile
withpoetry
to manage the dependencies for building other wheels, and updates the instructions accordingly.To do so, it freezes all bootstrap dependencies at the current state, except for the ones we no longer need.
Context
Our bootstrap is quite fragile due to being so dated, and changes to individual dependencies can either cause breakage, changes to existing wheels, or both. Most notably, we cannot update to the latest
Cython
until we have removed our use of PyYAML (freedomofpress/securedrop-client#1681), which is underway. Instead of opportunistic piecemeal updates, #464 proposes a full update of all bootstrap requirements, which I would suggest we do after we've removed PyYAML so we don't have to worry about that piece.Testing
To test this PR, try rebuilding the bootstrap by following the instructions in the README, with a test dependency such as
cowsay
, while on this branch:Check if you encounter errors or unexpected results (
git diff
) along the way.