libxo support for devinfo (take 2) #1480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilysh
reviewed
Oct 18, 2024
rilysh
reviewed
Oct 18, 2024
rilysh
reviewed
Oct 18, 2024
rilysh
reviewed
Oct 18, 2024
rilysh
reviewed
Oct 18, 2024
|
I'm learning about git rebase --interactive. Hold your horses. |
ktullavik
force-pushed
the
main
branch
3 times, most recently
from
b87feb1
to
72fe367
Compare
ktullavik
force-pushed
the
main
branch
8 times, most recently
from
e3eff60
to
6ed19d7
Compare
bsdimp
reviewed
Oct 20, 2024
bsdimp
reviewed
Oct 20, 2024
ktullavik
force-pushed
the
main
branch
2 times, most recently
from
e9b3034
to
3a48c3e
Compare
rilysh
reviewed
Oct 21, 2024
rilysh
reviewed
Oct 21, 2024
ktullavik
force-pushed
the
main
branch
5 times, most recently
from
0043583
to
5d33dcd
Compare
|
OK. That's this round. It looks to be mostly style. I'll test it on the next round to see if I can find some issues I'm not seeing in glancing over this. |
|
Also, the 3rd-5th commit messages need to have more descriptive titles. They are a little generic. Let me know if you want more specific suggestions. |
ktullavik
force-pushed
the
main
branch
2 times, most recently
from
68f708d
to
3967d4e
Compare
bsdimp
reviewed
Nov 5, 2024
|
Other than a couple of very minor style nits, the only thing I see is the strdup/refactoring suggestion I made. |
ktullavik
force-pushed
the
main
branch
4 times, most recently
from
1cdf3cc
to
6c7898e
Compare
When libxo is added we want the whole indentation to be printed in a single call. Otherwise the html will be spammed with indentation tags.
ktullavik
force-pushed
the
main
branch
2 times, most recently
from
6017e95
to
6038baa
Compare
…ture No functional change intended.
ktullavik
force-pushed
the
main
branch
2 times, most recently
from
2f50035
to
a0456b0
Compare
No functional change intended.
We'll need it twice when libxo is added. No functional change intended.
The code will diverge when libxo is added.
No functional change intended.
This is prep for libxo. No functional change intended.
This is prep for libxo. No functional change intended.
No functional change intended.
This is prep for libxo. No functional change intended.
This is prep for libxo. No functional change intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since last time I have
Many of the prep changes only makes sense once libxo are added.
I had to do quite a few contortions to retrofit libxo into this thing.